Which parts you make loose is largely personal preference or up to the concept that you’re working from, the sights could have gone either way.
I used edge loops instead of creases because it looks much better in almost all cases, though this might change with the OpenSubdiv crease options that are eventually coming to 2.8.
Hope that helps, happy modeling!